if, elseif, else

if thats a direct cut and paste then the problem is with the part in red missing an IF

in future it might be better to paste the error message aswell

if request("state") = "test" then sSQL="SELECT * FROM computer ORDER BY siteTitle"  elseif request("state") = "test2" then sSQL="SELECT * FROM computer ORDER BY id"    else request("state") = "test3" then sSQL="SELECT * FROM computer ORDER BY url"  end if

but i think it might be better to have

select case request("state")     case "test"         sSQL="SELECT * FROM computer ORDER BY siteTitle"     case "test2"         sSQL="SELECT * FROM computer ORDER BY id"     case "test3"         sSQL="SELECT * FROM computer ORDER BY url" end select

If then statements are pretty slow. A case statement is many times faster.

Also, if you're using the request object, it's a good practice to trim it to remove any leading or trailing spaces - e.g. Trim(Request("state").

Another good practice is specifying Request.Form (assuming state is a form field) as that will keep someone from entering the info via a url query string and perhaps bypassing any validation or security. Spammers like contact forms that just use the request object instead of specifying request.form.


Edited by dpyers - 05 October 2006 at 1:23am