Some suggestions for improvement

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   My boss bought this application, and now wants me to create some enhancements. So i am working on that.

I must say that there is some room for improvement of the code. To give you a few suggestions:

sign_up.asp

-----------

1. Checking if an email address is on the "banned" list does not require to get all banned email addresses in a recordset, and then looping through it, and check for each record if it is equal with the submitted email address. Since long there is a way to let the database do that selection job. It is called SQL, and it looks like this:

SELECT fieldnames FROM table WHERE condition

Where the "condition" is the crux. It saves a lot of performance to let the database do the selection on the criteria, because the database is designed to do that. Especially if you put an index of the column "Email" (which it hasn't when installed). ADODB Recordsets are not. Even though there have a Filter property which also can be used (and which is faster then just looping through the complete recordset)

* Just below that, I see code that is to update the users information (or to insert a new user). Here the code uses the same procedure: get all records from all users and loop through it to see if one matches the current user (as defined by email address). It is just way too much overhead to create a recordset with all users that are subscribed. Again, let the database do the selection. SQL is the solution.

I am afraid that without changing these examples the application will rapidly decrease in performance with a larger number of subscribers.

functions_hash1way.asp

----------------------

I see many functions that do what VBScript can do standard. Some examples:

* BinaryAND(), BinaryOR().

The VBScript "AND" and "OR" operators are capable of handling bitwise comparing. From the VBS-helpfile:

"The And operator also performs a bitwise comparison of identically positioned bits in two numeric expressions and sets the corresponding bit in result according to the following table: ......"

(comparable text for operator "OR").

So there is no need to have (slow) self-defined functions for this.

* getDecHex().

Dito, it equals native VBScript function Hex().

With some thinking all functions in this include could be much faster.

I hope you don't mind that i am pointing to things like this. To be honest, I will probably gradually rewrite the complete code. When I am done, I'll send you a copy, ok?