ASP.NET Discussion - Review Requested.

Print Page | Close Window

Review Requested.

Printed From: Web Wiz Forums
Category: General Discussion
Forum Name: ASP.NET Discussion
Forum Description: Discussion and chat on ASP.NET related topics.
URL: https://forums.webwiz.net/forum_posts.asp?TID=20234
Printed Date: 28 March 2026 at 5:31pm
Software Version: Web Wiz Forums 12.08 - https://www.webwizforums.com

Topic: Review Requested.

Posted By: davidshq
Subject: Review Requested.
Date Posted: 09 June 2006 at 3:39am

I've got a functional demo of my new site up at www.betterneighbours.com. It was written entirely in ASP.NET 2.0 and SQL Server 2005. I'd appreciate anyone who would surf around and see if they can find any code flaws.
David.

-------------
- http://www.davemackey.net/" rel="nofollow - Dave Mackey - Virtual Home.

Replies:

Posted By: michael
Date Posted: 09 June 2006 at 2:02pm

Site seems nice few things I noticed. When you are not logged in and click in request item for an item, nothing happens.
When you register it kicks you back to a "Please register site" trying to login after that brings you to the registration form. It appears my registration details were invalid i.e. Password not complex enough and you pushed somewhere else not showing the details.
Seconds time worked fine.
Then after registering and requesting an item I get the dreaded YSoD.


Server Error in '/' Application.

--------------------------------------------------------------------------------



Input string was not in a correct format. 

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code. 



Exception Details: System.FormatException: Input string was not in a correct format.



Source Error: 





Line 40:         For Each row As GridViewRow In GridView1.Rows

Line 41:             Dim varuser As String = row.Cells(3).Text

Line 42:             If row.Cells(5).Text > 1 Then

Line 43:                 If String.IsNullOrEmpty(row.Cells(3).Text) = False Then

Line 44:                     If row.Cells(3).Text <> " " Then

 



Source File: E:\Domains\betterneighbours.com\wwwroot\MyRequests.aspx.vb    Line: 42 



Stack Trace: 





[FormatException: Input string was not in a correct format.]

   Microsoft.VisualBasic.CompilerServices.Conversions.ParseDouble(String Value, NumberFormatInfo NumberFormat) +211

   Microsoft.VisualBasic.CompilerServices.Conversions.ToDouble(String Value, NumberFormatInfo NumberFormat) +74



[InvalidCastException: Conversion from string "Available" to type 'Double' is not valid.]

   Microsoft.VisualBasic.CompilerServices.Conversions.ToDouble(String Value, NumberFormatInfo NumberFormat) +218

   Microsoft.VisualBasic.CompilerServices.Conversions.ToDouble(String Value) +6

   MyRequests.GridView1_RowDataBound(Object sender, GridViewRowEventArgs e) in E:\Domains\betterneighbours.com\wwwroot\MyRequests.aspx.vb:42

   System.Web.UI.WebControls.GridView.OnRowDataBound(GridViewRowEventArgs e) +105

   System.Web.UI.WebControls.GridView.CreateRow(Int32 rowIndex, Int32 dataSourceIndex, DataControlRowType rowType, DataControlRowState rowState, Boolean dataBind, Object dataItem, DataControlField[] fields, TableRowCollection rows, PagedDataSource pagedDataSource) +233

   System.Web.UI.WebControls.GridView.CreateChildControls(IEnumerable dataSource, Boolean dataBinding) +3146

   System.Web.UI.WebControls.CompositeDataBoundControl.PerformDataBinding(IEnumerable data) +59

   System.Web.UI.WebControls.GridView.PerformDataBinding(IEnumerable data) +11

   System.Web.UI.WebControls.DataBoundControl.OnDataSourceViewSelectCallback(IEnumerable data) +111

   System.Web.UI.DataSourceView.Select(DataSourceSelectArguments arguments, DataSourceViewSelectCallback callback) +29

   System.Web.UI.WebControls.DataBoundControl.PerformSelect() +149

   System.Web.UI.WebControls.BaseDataBoundControl.DataBind() +70

   System.Web.UI.WebControls.GridView.DataBind() +4

   System.Web.UI.WebControls.BaseDataBoundControl.EnsureDataBound() +82

   System.Web.UI.WebControls.CompositeDataBoundControl.CreateChildControls() +69

   System.Web.UI.Control.EnsureChildControls() +87

   System.Web.UI.Control.PreRenderRecursiveInternal() +41

   System.Web.UI.Control.PreRenderRecursiveInternal() +161

   System.Web.UI.Control.PreRenderRecursiveInternal() +161

   System.Web.UI.Control.PreRenderRecursiveInternal() +161

   System.Web.UI.Control.PreRenderRecursiveInternal() +161

   System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +1360



 





--------------------------------------------------------------------------------

Version Information: Microsoft .NET Framework Version:2.0.50727.42; ASP.NET Version:2.0.50727.42

Enough testing for now :)

Good job so far though.

-------------
http://baumannphoto.com" rel="nofollow - Blog | http://mpgtracker.com" rel="nofollow - MPG Tracker

Posted By: davidshq
Date Posted: 10 June 2006 at 2:22am

Thanks for the feedback. I've corrected the error on the MyRequests page. I'd changed the value of a cell dynamically to text, but was still trying to perform a mathematical comparison on it, which of course, doesn't work.
Concerning the page redirect when entering invalid information, I double-checked to ensure that password complexity was disabled (you can use any password of one character or more), and will continue to look into that issue.
Thanks again.
David.

-------------
- http://www.davemackey.net/" rel="nofollow - Dave Mackey - Virtual Home.

Posted By: dpyers
Date Posted: 10 June 2006 at 3:59pm

interesting concept. I'd like to see this site take off.
In FireFox, the body text overlaps the login area.
The select state drop-down has 3 or 4 blank entries in it. If you hit "go" on one of the blanks it loads default.aspx but without the drop down.

-------------

Lead me not into temptation... I know the short cut, follow me.

Posted By: davidshq
Date Posted: 11 June 2006 at 5:07am

Dpyers,
   Thanks for the feedback. The funny thing is, I am using Firefox and not seeing any overlap of the body text with the login area.
    I did however correct the problem with blank rows in the states drop down.
    I also added a wanted feature so that you can request items you want, as well as post items you have available.
    I hope as well that it will take off, I think it is a good concept, it will just depend on people's willingness to list items.
David.

-------------
- http://www.davemackey.net/" rel="nofollow - Dave Mackey - Virtual Home.

Posted By: dpyers
Date Posted: 12 June 2006 at 12:24am

I'm using FF 1.5.0.4
1280x1024 and large (120%) fonts.
Overlaps even if I increase/decrease font size though.

-------------

Lead me not into temptation... I know the short cut, follow me.