| Author |
Topic Search Topic Options
|
xeerex
Senior Member
Joined: 19 November 2002
Location: United States
Status: Offline
Points: 601
|
Posted: 13 November 2004 at 11:14am |
Hi -borg-,
I just tested the new RTE. Very nice.
Here are 2 minor issues that I saw under FireFox 1.0 with WinXP.
- The "justify" button does not do a full justify. It appears to
only do a left justify exactly like the actual left justify button.
- If I insert a horizontal rule, then by default that rule is set
to size 2. If I try to use the HTML view and modify the size it will
not let me. I can manually edit most of the other tags, but that one
acts very odd.
Also, you mentioned that this one will be much easier to implement.
This issue was one of the reasons that I looked into some other editors
over your last one. If you can get it much easier to implement, then
I'm definitely "sold" on it. It looks great!
|
|
|
 |
mack
Groupie
Joined: 06 November 2004
Location: United States
Status: Offline
Points: 90
|
Posted: 13 November 2004 at 12:07pm |
|
Very nice job boRg, it looks great. Mozilla Firefox no longer types all weird :)!
Anythere, there is one bug I found. In IE, when you type a link
(www.webwiz.net) it automatically creates it as a LINK. In
Mozilla, as you can see it did not work. Even with http:// in front,
see: http://webwiz.net.
Another thing is the "Hyperlink properties". I don't see a point in
loading a "Preview". I can't even push OK on the dialog, because it
isn't enabled. Also, the preview page goes to http://www.altavista.com/
for some reason. I really don't see a point in a preview button for it.
If there is, explain please :)
Thank you and GOOD job!
|
 |
dpyers
Senior Member
Joined: 12 May 2003
Status: Offline
Points: 3937
|
Posted: 13 November 2004 at 12:32pm |
-boRg- wrote:
MadDog wrote:
-boRg-, have you ever tried to create a function for when someone presses enter it takes that and just enters "<br>" instead of "<p></p>"? I thought i saw something a long time ago on a java script websites that did that. If i run across it again ill post it. |
Already done, if you use IE on the new editor, if you hit return it puts in a <br> instead of <p>, so you don't get those annoying double line spaces.
|
Using <br> instead of <p> replaces a block tag with an inline tag and screws up the list functionality.
A better solution would be an rte style sheet with <p> magin-bottom and padding-bottom set to 0.
|
Lead me not into temptation... I know the short cut, follow me.
|
 |
dpyers
Senior Member
Joined: 12 May 2003
Status: Offline
Points: 3937
|
Posted: 13 November 2004 at 12:34pm |
|
Note: - when I tested the llist functionality it was with ie6. FF works ok.
|
Lead me not into temptation... I know the short cut, follow me.
|
 |
WebWiz-Bruce
Admin Group
Web Wiz Developer
Joined: 03 September 2001
Location: Bournemouth
Status: Offline
Points: 9844
|
Posted: 13 November 2004 at 12:49pm |
xeerex wrote:
Hi -borg-,
I just tested the new RTE. Very nice.
Here are 2 minor issues that I saw under FireFox 1.0 with WinXP.
- The "justify" button does not do a full justify. It appears to
only do a left justify exactly like the actual left justify button.
- If I insert a horizontal rule, then by default that rule is set
to size 2. If I try to use the HTML view and modify the size it will
not let me. I can manually edit most of the other tags, but that one
acts very odd.
Also, you mentioned that this one will be much easier to implement.
This issue was one of the reasons that I looked into some other editors
over your last one. If you can get it much easier to implement, then
I'm definitely "sold" on it. It looks great!
|
I have exactly the same setup and I can not replicate either the problems you mention
|
|
|
 |
WebWiz-Bruce
Admin Group
Web Wiz Developer
Joined: 03 September 2001
Location: Bournemouth
Status: Offline
Points: 9844
|
Posted: 13 November 2004 at 12:56pm |
mack wrote:
Very nice job boRg, it looks great. Mozilla Firefox no longer types all weird :)!
Anythere, there is one bug I found. In IE, when you type a link
(www.webwiz.net) it automatically creates it as a LINK. In
Mozilla, as you can see it did not work. Even with http:// in front,
see: http://webwiz.net.
Another thing is the "Hyperlink properties". I don't see a point in
loading a "Preview". I can't even push OK on the dialog, because it
isn't enabled. Also, the preview page goes to http://www.altavista.com/
for some reason. I really don't see a point in a preview button for it.
If there is, explain please :)
Thank you and GOOD job!
|
IE will turn any http://www.www.com address automactiacally into a
hyperlink, this is a built in fetaure of the browser and something that
Mozilla didn't put into their RTE implementation.
You should be able to insert a hyperlink without first previewing it.
The preview feature is only there so you can check the link is correct
before inserting it.
In Firefox if you enter a word instead of a hyperlink into the browser
address bar it will automactically do a google search and open up the
first site google returns in your browser window. As the preview
feature only opens a web page in the same way but in an iframe, if you
type just a word into the hyperlink space and click to preview it will
set Firefox off doing a google search and displaying the first page a
google search returns in the iframe.
|
|
|
 |
WebWiz-Bruce
Admin Group
Web Wiz Developer
Joined: 03 September 2001
Location: Bournemouth
Status: Offline
Points: 9844
|
Posted: 13 November 2004 at 1:07pm |
dpyers wrote:
-boRg- wrote:
MadDog wrote:
-boRg-, have you ever
tried to create a function for when someone presses enter it takes that
and just enters "<br>" instead of "<p></p>"? I
thought i saw something a long time ago on a java script websites that
did that. If i run across it again ill post it. |
Already
done, if you use IE on the new editor, if you hit return it puts in a
<br> instead of <p>, so you don't get those annoying double
line spaces.
|
Using <br> instead of <p> replaces a block tag with an inline tag and screws up the list functionality.
A better solution would be an rte style sheet with <p> magin-bottom and padding-bottom set to 0. |
I did look into using CSS to set the <p> tag, but
then when you submit the form it will still be submitted with the
<p> tag so when you try and display the input in something like a
forum it will still have <p>, unless you use CSS to change all
<p> tags on the page it is displayed in, which isn't always
practicle.
The list functionality still works, but is a little quirly now, you
have to go to the begining of the last block ahd hit return to remove
the list from it.
The implementation I found at the moment is the best comprimise I can
find, I have tried many ways to do it differently using CSS etc. over
the last 3 years.
It's just a shame that IE have choose in their RTE implementaion to
have a <p> tag when you hit return and many people do complain
about it.
The only solution I have found is that now when you hit return, is that
it detects that a return key is pressed, then inserts a <br> tag
instead of a <p> tag.
It took me the best part of 8 or 9 hours or trial, error and testing to
come up with the following small function to insert <br> in IE
instead of <p>. (This function is for IE only, Firefox have
implemented the return key to insert a <br> tag already, so this
function isn't required for Gecko based browsers)
//Detect if the enter key is pressed
function IEkeypress(){
//run if enter key is pressed
if (frames.message.window.event.keyCode==13){
var editor = document.getElementById('message')
var selectedRange = editor.contentWindow.document.selection.createRange();
var parentElement = selectedRange.parentElement();
var tagName = parentElement.tagName;
while((/^(a|abbr|acronym|b|bdo|big|cite|
code|dfn|em|font|i|kbd|label|q|s|samp|select|small|span|st ri
ke|strong|sub|sup|textarea|tt|u|var)$/i.test(tagName))
& ;& (tagName!='HTML')){
parentElement = parentElement.parentElement;
tagName = parentElement.tagName;
}
//Insert <br> instead of <p>
if (parentElement.tagName == 'P'
|| parentElement.tagName == 'BODY' || parentElement.tagName == 'HTML'
|| parentElement.tagName == 'TD' || parentElement.tagName == 'THEAD' ||
parentElement.tagName == 'TFOOT'){
selectedRange.pasteHTML('<br >');
selectedRange.select();
return false;
}
}
return true;
} |
Edited by -boRg-
|
|
|
 |
dpyers
Senior Member
Joined: 12 May 2003
Status: Offline
Points: 3937
|
Posted: 13 November 2004 at 1:29pm |
One suggestion I can think of for dealing with list elements would be to insert the <p> tag if the user uses shift-enter - the reverse of the way the current version inserts the <br> tag instead of a <p> tag.
Alternatively, you could insert <p class="rte" style="margin:0px;padding:opx;"> </p> around the ul/ol tags. Or instead of
selectedRange.pasteHTML('<br >');
|
use the inline stle within the <p> tag to override any css margin/padding on the displayed page.
selectedRange.pasteHTML('<p style="margin:0px 0px 0px 0px;margin:0px 0px 0px 0px;>');
|
|
Lead me not into temptation... I know the short cut, follow me.
|
 |